fix: Create tmp directory without using app name#1585
Merged
felixrieseberg merged 1 commit intomainfrom Oct 25, 2023
Merged
Conversation
|
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
felixrieseberg
changed the title
MarshallOfSound
approved these changes
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
- Coverage 95.58% 95.46% -0.13%
==========================================
Files 15 15
Lines 793 793
==========================================
- Hits 758 757 -1
- Misses 35 36 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5 tasks
|
Thanks for your contribution! 🎉 |
|
🎉 This PR is included in version 18.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes: Fix: Don't use app name when creating temporary directories, ensuring that npm scripts expecting paths without spaces will work fine.